Skip to content

⚡ Bolt: optimize badge evaluation with O(1) transient query cache - #131

Open
projectamazonph wants to merge 4 commits into
mainfrom
perf/badge-eval-cache-14041009131358730160
Open

⚡ Bolt: optimize badge evaluation with O(1) transient query cache#131
projectamazonph wants to merge 4 commits into
mainfrom
perf/badge-eval-cache-14041009131358730160

Conversation

@projectamazonph

@projectamazonph projectamazonph commented Aug 13, 2026

Copy link
Copy Markdown
Owner

What

  • Introduced a transient EvaluationCache class within src/lib/badges.ts.
  • Replaced multiple individual/redundant database reads (lessonProgress.count, toolSession.count, and user.findUnique) inside the criteria-checking loop with cached promise resolutions.

Why

  • Previously, checking criteria for each badge during evaluateBadges would execute a database query per rule checked (producing O(R) database roundtrips where R is the number of badge rules).
  • As the number of defined badges and criteria grows, this triggers high database load and query latency.

Impact

  • Redundant database roundtrips are collapsed from O(R) to O(1).
  • Re-use of query promises ensures database read operations are executed at most once per evaluateBadges invocation.

Measurement

  • Run DATABASE_URL="postgresql://localhost:5432/test" pnpm test to verify that existing badge engine test suites and other integration tests continue to pass with 100% success.
  • Typecheck and lint pass successfully without issues.

PR created automatically by Jules for task 14041009131358730160 started by @projectamazonph

@google-labs-jules @projectamazonph
perf(badges): introduce EvaluationCache for O(1) DB query promise sha…
313cc05 
…ring during evaluation

Introduce a transient `EvaluationCache` to cache and share database query promises (for module completion count, tool session count, and user details) across rules during a single badge evaluation cycle. This collapses database roundtrips from O(R) to O(1), where R is the number of badge criteria, while keeping the logic fully composable and clean.

Co-authored-by: projectamazonph <286085559+projectamazonph@users.noreply.github.com>
@google-labs-jules

google-labs-jules Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

Copilot AI lite review requested due to automatic review settings August 13, 2026 13:45
Copilot AI reviewed Aug 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

@projectamazonph, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8050f1da-c25d-4fcd-a4f3-6ab706753b3d

📥 Commits

Reviewing files that changed from the base of the PR and between 9d0e0bf and f511266.

📒 Files selected for processing (4)
  • .jules/bolt.md
  • package.json
  • src/lib/__tests__/badges.test.ts
  • src/lib/badges.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

google-labs-jules Bot and others added 3 commits August 13, 2026 13:51
@google-labs-jules @projectamazonph
perf(badges): introduce EvaluationCache for O(1) DB query promise sha…
21fd7a5 
…ring and pin stable pnpm version

- Introduce a transient `EvaluationCache` to cache and share database query promises across rules during badge evaluation, reducing database roundtrips from O(R) to O(1).
- Pin `packageManager` to `pnpm@11.12.0` in package.json to resolve a broken GitHub Actions self-installer block with pnpm v11.13.0 (missing binary in @pnpm/exe release).

Co-authored-by: projectamazonph <286085559+projectamazonph@users.noreply.github.com>
@google-labs-jules @projectamazonph
perf(badges): introduce EvaluationCache for O(1) DB query promise sha…
973ab87 
…ring and pin stable pnpm version

- Introduce a transient `EvaluationCache` to cache and share database query promises across rules during badge evaluation, reducing database roundtrips from O(R) to O(1).
- Pin `packageManager` to `pnpm@11.11.0` in package.json to resolve a broken GitHub Actions self-installer block with pnpm v11.13.0 and v11.12.0 (missing binary in @pnpm/exe release).

Co-authored-by: projectamazonph <286085559+projectamazonph@users.noreply.github.com>
@google-labs-jules @projectamazonph
perf(badges): introduce EvaluationCache for O(1) DB query promise sha…
f511266 
…ring and bump branch coverage to 73.97%

- Introduce a transient `EvaluationCache` to cache and share database query promises across rules during badge evaluation, reducing database roundtrips from O(R) to O(1).
- Add robust unit tests for EvaluationCache and checkCriteria to raise overall branch coverage to 73.97%, meeting the Quality Gates threshold.
- Pin `packageManager` to `pnpm@11.11.0` in package.json to resolve a broken GitHub Actions self-installer block with pnpm v11.13.0 and v11.12.0 (missing binary in @pnpm/exe release).

Co-authored-by: projectamazonph <286085559+projectamazonph@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@projectamazonph