[scanner] fix: redirect Bazaar Zed installs - #1011
Open
kubestellar-hive[bot] wants to merge 1 commit into
Open
Conversation
![scanner[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Signed-off-by: scanner[bot] <scanner[bot]@users.noreply.github.com>
kubestellar-hive
Bot
requested review from
ahmedadan and
hanthor
as code owners
August 20, 2026 17:46
hanthor
requested changes
Sep 2, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
spawn_brew() in hooks.py runs {brew} tap --trust {tap} && {brew} install --cask {app} for the new Zed hook. brew tap --trust is invalid on Homebrew 6.0 — confirmed by this repo's own docs/skills/brew-lifecycle guidance and by sibling PR #978 (also in this review pass), which exists specifically to eliminate this exact pattern elsewhere in the repo. Homebrew 6.0 blocks untrusted taps silently, so the Zed install flow this PR adds will silently fail to trust the tap. Needs {brew} tap {tap} && {brew} trust {tap} && ... instead. CI's test job passed only because the unit tests assert the hook's state-machine responses, not the actual brew command syntax, so this wasn't caught.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix\n\nAdd Bazaar hook for dev.zed.Zed so users can choose supported Zed Homebrew cask installation instead of an unsupported Flatpak. Tap experimental Universal Blue repository before install and add state-machine regression coverage.\n\nRefs projectbluefin/dakota#609\n\n---\nFiled by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=scanner backend=copilot model=gpt-5.6-luna