feat: Make fluent_syntax::parser::core::Parser pub - #394
danielrainer wants to merge 1 commit into
Conversation
1aa02b5 to
9535bd7
Compare
danielrainer
changed the title
fluent_syntax::parser::core::Parser pubfluent_syntax::parser::core::Parser pub
This allows creating a simple FTL formatter by parsing and then immediately serializing the parsing result again.
9535bd7 to
cf712bc
Compare
|
I just played around with this some more and it turns out that with |
This fork differs from mainline `fluent-rs` by a single line, which makes `Parser` from the `fluent-syntax` crate public. We need this because our code depends on the parser for much of its functionality. There is an open PR for this, but so far it hasn't been addressed: projectfluent/fluent-rs#394
|
@danielrainer Is this in use via your fork for Fish shell now? Or via patches in Debian? At first glance it seems pretty reasonable, but there are a couple of questions about the things this drags with it and whether that's API surface we really want to support as part of the versioning contract. It would help if you could comment on what method(s) or other access is necessary to be public to be useful. A number of things inside And sorry for the long delay in review. |
2 participants
This allows creating a simple FTL formatter by parsing and then immediately serializing the parsing result again.