Repository navigation
[ARM64_DYNAREC] Fixed BOUND leaking a cleared deferred flags state - #4633
Merged
Merged
Conversation
The BOUND handler emits a conditional CALL_S() and then continues. call_c() clears df and sets dyn->f to status_none, but only on the taken path. The fall-through kept a pending df while the codegen thought it was cleared, so the stale deferred op was re-applied later and corrupted the flags. Save and restore dyn->f around that call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BOUND handler emits a conditional CALL_S() and then continues. call_c() clears df and sets dyn->f to status_none, but only on the taken path. The fall-through kept a pending df while the codegen thought it was cleared, so the stale deferred op was re-applied later and corrupted the flags. Save and restore dyn->f around that call.