Skip to content

Promote develop to main: CeilSense Boot LED Fix - #241

Merged
ptr727 merged 2 commits into
mainfrom
develop
Oct 15, 2026
Merged

ptr727 merged 2 commits into
mainfrom
develop

Conversation

@ptr727

@ptr727 ptr727 commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

What

Promotes #240 to main.

  • The CeilSense template's boot phase 1 now turns the status LED loading effect on only while the vendor's Startup LED Self-Test switch is on, as the vendor's own phase 1 does. Before this, the ring kept spinning after boot because the vendor turns the LED off at the end of boot only when that switch is on.

#238 rides along. It moves the hub reusable workflow pins from 2.0.983, which #239 set on main, to 2.0.1004.

Behavior

Changes templates/smarthome-ceilsense.yaml, which garage-presence-sensor.yaml consumes. With the self-test switch off, the default, the status LED stays off after boot instead of spinning.

Verification

  • Compiled on ESPHome 2026.9.1 and flashed to the garage sensor over OTA. Home Assistant reports the status LED off after boot.
  • #240: Copilot covered its head with no findings, CodeRabbit generated no actionable comments, and the local strict review's second pass found nothing.

🤖 Generated with Claude Code

dependabot Bot and others added 2 commits October 15, 2026 06:06
Bumps the actions-deps group with 4 updates: [ptr727/ProjectTemplate/.github/workflows/merge-bot-task.yml](https://github.com/ptr727/projecttemplate), [ptr727/ProjectTemplate/.github/workflows/publish-plan-task.yml](https://github.com/ptr727/projecttemplate), [ptr727/ProjectTemplate/.github/workflows/validate-task.yml](https://github.com/ptr727/projecttemplate) and [ptr727/ProjectTemplate/.github/workflows/build-release-task.yml](https://github.com/ptr727/projecttemplate).


Updates `ptr727/ProjectTemplate/.github/workflows/merge-bot-task.yml` from 2.0.983 to 2.0.1004
- [Release notes](https://github.com/ptr727/projecttemplate/releases)
- [Changelog](https://github.com/ptr727/ProjectTemplate/blob/main/HISTORY.md)
- [Commits](ptr727/ProjectTemplate@0c93369...098016c)

Updates `ptr727/ProjectTemplate/.github/workflows/publish-plan-task.yml` from 2.0.983 to 2.0.1004
- [Release notes](https://github.com/ptr727/projecttemplate/releases)
- [Changelog](https://github.com/ptr727/ProjectTemplate/blob/main/HISTORY.md)
- [Commits](ptr727/ProjectTemplate@0c93369...098016c)

Updates `ptr727/ProjectTemplate/.github/workflows/validate-task.yml` from 2.0.983 to 2.0.1004
- [Release notes](https://github.com/ptr727/projecttemplate/releases)
- [Changelog](https://github.com/ptr727/ProjectTemplate/blob/main/HISTORY.md)
- [Commits](ptr727/ProjectTemplate@0c93369...098016c)

Updates `ptr727/ProjectTemplate/.github/workflows/build-release-task.yml` from 2.0.983 to 2.0.1004
- [Release notes](https://github.com/ptr727/projecttemplate/releases)
- [Changelog](https://github.com/ptr727/ProjectTemplate/blob/main/HISTORY.md)
- [Commits](ptr727/ProjectTemplate@0c93369...098016c)

---
updated-dependencies:
- dependency-name: ptr727/ProjectTemplate/.github/workflows/merge-bot-task.yml
  dependency-version: 2.0.1004
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions-deps
- dependency-name: ptr727/ProjectTemplate/.github/workflows/publish-plan-task.yml
  dependency-version: 2.0.1004
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions-deps
- dependency-name: ptr727/ProjectTemplate/.github/workflows/validate-task.yml
  dependency-version: 2.0.1004
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions-deps
- dependency-name: ptr727/ProjectTemplate/.github/workflows/build-release-task.yml
  dependency-version: 2.0.1004
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions-deps
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Gate the CeilSense Boot LED on the Vendor's Self-Test Switch

The vendor made its startup LED self-test opt-in, gating both the phase 1
loading effect and the final turn-off on the Startup LED Self-Test switch.
The template's stand-in for the unimported wifi.yaml phase 1 still turned
the effect on unconditionally, so with the switch off nothing turned it
off and the ring kept spinning after boot. Phase 1 now checks the same
switch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Describe the CeilSense phase 1 LED gate as the vendor's own

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 15, 2026 14:40
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9a775712-cde7-41c0-9cd6-e6592f589c98
📥 Commits

Reviewing files that changed from the base of the PR and between d27eeb6 and 7c5bb0d.

📒 Files selected for processing: 4
  • .github/workflows/merge-bot-pull-request.yml
  • .github/workflows/publish-release.yml
  • .github/workflows/test-pull-request.yml
  • templates/smarthome-ceilsense.yaml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ptr727 ptr727 added the comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses label Oct 15, 2026
@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.07%. Comparing base (7d7c3f9) to head (7c5bb0d).
⚠️ Report is 44 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   43.07%   43.07%           
=======================================
  Files           1        1           
  Lines         130      130           
=======================================
  Hits           56       56           
  Misses         74       74           
Flag Coverage Δ
python-3.13 43.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

0 open findings

What changed in this PR

Promotes the CeilSense boot LED fix and updates reusable workflow pins to 2.0.1004.

Changes:

  • Gates the boot loading effect on the startup self-test switch.
  • Updates CI, release, and merge-bot workflow references.
File Description
templates/​smarthome-ceilsense.yaml Gates startup LED activation.
.github/​workflows/​test-pull-request.yml Updates validation workflow pin.
.github/​workflows/​publish-release.yml Updates validation workflow pin.
.github/​workflows/​merge-bot-pull-request.yml Updates merge-bot workflow pin.

🧠 Review effort: Lite


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ptr727
ptr727 merged commit a249bd0 into main Oct 15, 2026
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants