Skip to content

Tell a Timed-Out Node Probe From an Engine Disagreement in test_spec_validate #3182

Closed

Description

@ptr727

The shape

test_spec_validate.RegistrySchemaMirrorCase.test_both_engines_agree_on_every_pattern_over_a_corpus runs a node -e probe under subprocess.run(..., timeout=60). On the Windows unit test job of #3181, which changes only pr_review.py and its tests, the probe hit that timeout and raised subprocess.TimeoutExpired. A re-run of the same commit passed. The same test passed on Windows for #3179 earlier the same day.

The probe compiles each registry pattern with new RegExp and tests it against a small corpus. That is milliseconds of work, so the 60 seconds went to the runner rather than the regex. The failure is a timeout, so it gives no verdict on the patterns.

Expected

One of these:

  • The test separates a probe that timed out from one that disagreed. For example, it could report a TimeoutExpired as an execution boundary that skips, distinct from an engine disagreement that fails.
  • Or the budget is sized for a cold Node start on a hosted Windows runner.

Either way, a slow runner should not read as a broken schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions