Repository navigation
Drop the Claim That No Worktree Outlives an Unattended Lane - #3191
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
A recorded local strict-review pass covers head |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes address the inaccurate cleanup guarantee, with no unresolved issues.
No open issues 🎉
What changed in this PR
Updates unattended-handoff to remove the incorrect guarantee that cleanup always succeeds.
Changes:
- Corrects cleanup and failure-reporting instructions.
- Regenerates GitHub and Claude skill copies.
- Updates the source digest.
| File | Description |
|---|---|
.github/skills/unattended-handoff/SKILL.md |
Updated skill instructions. |
.claude-plugin/fleet-skills/skills/unattended-handoff/SKILL.md |
Regenerated skill copy. |
.claude-plugin/fleet-skills/.source-digests/unattended-handoff |
Updated source digest. |
.agents/skills/unattended-handoff/SKILL.md |
Updated canonical skill instructions. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3191 +/- ##
===========================================
- Coverage 65.46% 65.44% -0.03%
===========================================
Files 17 17
Lines 9750 9750
===========================================
- Hits 6383 6381 -2
- Misses 3367 3369 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ptr727
added a commit
that referenced
this pull request
Oct 17, 2026
- #3186 adds the local half of post-merge cleanup to `pr_review.py cleanup`. With `--checkout <base-clone>`, it removes the merged branch's worktrees and local branch after the remote delete and fast-forwards the base clone's `develop`. `cleanup --sweep` reports, and with `--apply` removes, the worktrees and branches an interrupted or abandoned session left behind. - #3188 points every skill that finishes a worktree at those commands, in place of the raw `git worktree remove`, `git branch -D`, and remote delete, which the host-safety allowlist does not cover. The skills are `repo-worktree`, `drive-pr`, `merge-and-release`, `backlog-burndown`, `pr-review-conduct`, `unattended-handoff`, `resync-a-repo`, and `audit-a-repo`. `git-commit-conventions`'s post-squash `-D` exception now admits a tip behind the verified head. - #3190 fixes a promotion-review finding. `cleanup --sweep` now judges a branch held only by a pruned worktree entry in the same run, rather than skipping it until the next. - #3191 fixes a second promotion-review finding. `unattended-handoff` step 7 no longer claims that no worktree outlives the lane, and it names a cleanup that could not run or that failed. Installed Skills change at release. Closes #3184 Closes #1682 Closes #1693 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a previously-missed finding raised on promotion #3189. Step 7 of
unattended-handoffsaid that because each merged pull request haddrive-prstep 4's cleanup run, "no finished worktree or branch outlives the lane". That is false when the cleanup could not run or exited non-zero.The step is now the bare instruction. Each merged pull request is cleaned up per
drive-prstep 4. A cleanup that could not run, or exited other than0, is named in the close-out comment with its output, rather than finished by hand.Local review
Two recorded
local-strict-reviewpasses ran at thefrontiertier. The first found that the rewrite added two claims of the same kind: what a failed cleanup leaves, and that cleanup ran at all. Both were cut. Nothing remains open.🤖 Generated with Claude Code