raise ValueError for unsupported name attribute value tags#15076
Open
dxbjavid wants to merge 1 commit into
Open
raise ValueError for unsupported name attribute value tags#15076dxbjavid wants to merge 1 commit into
dxbjavid wants to merge 1 commit into
Conversation
alex
reviewed
Jun 28, 2026
| # UTF8String tag with an unsupported tag value. The first occurrence | ||
| # is the issuer name. | ||
| idx = der.index(b"\x06\x03\x55\x04\x03") | ||
| der[idx + 5] = 0x69 |
Member
There was a problem hiding this comment.
The right way to do these tests is with a checked in vector, not by generating and then manipulating the value
| let py_tag = types::ASN1_TYPE_TO_ENUM | ||
| .get(py)? | ||
| .get_item(tag_val) | ||
| .map_err(|_| asn1::ParseError::new(asn1::ParseErrorKind::InvalidValue))?; |
Member
There was a problem hiding this comment.
I think UnexpectedTag is a more correct error to return here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing an X.509 name attribute whose value carries an ASN.1 tag outside the recognised string types looked the tag up in the _ASN1_TYPE_TO_ENUM dict without handling a miss, so a crafted certificate, CSR, CRL or OCSP response made accessing subject or issuer raise a bare KeyError rather than the ValueError every other malformed-input path raises. The value itself is already accepted into the catch-all AnyString variant, so only the type lookup was left unguarded. I map the miss to an invalid-value parse error so it surfaces as a ValueError with the usual field location, and add a regression test that mutates a built certificate's commonName tag.