Simplify subprocess communication in _runopenssl helper#1522
Merged
Conversation
Recent typeshed changed Popen.stdout from IO[AnyStr] to IO[Any], so reading from it directly returns Any and trips no-any-return. Use Popen.communicate(), which is still generically typed and does the same write/close/read/wait dance. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHw2uDgLcFsTfoStC4tzGv
Member
Author
|
mypy error 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the
_runopensslhelper function in the crypto tests to usesubprocess.Popen.communicate()instead of manually managing stdin/stdout pipes.Key Changes
communicate()callImplementation Details
The
communicate()method is the recommended way to interact with subprocesses as it:This change improves code clarity and follows subprocess best practices.
https://claude.ai/code/session_01FHw2uDgLcFsTfoStC4tzGv