FIX: Fix update points to correctly index by accounting for state variables - #63
Merged
Merged
Conversation
Since the Workspace integration (0.3.0), _update_points sliced compset.dof[:sum(dof)], but CompositionSet.dof is laid out as [state variables..., site fractions...], so the leading N/P/T values were taken as the equilibrium point. After per-sublattice normalization in local_sample the adaptive points were nowhere near the actual equilibrium constitution. Skip the state variables when extracting the equilibrium site fractions and add regression tests for _update_points.
bocklund
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to the
Workspacechanges in 0.3.0,_update_pointswas indexing intoeq.Y[vtx, :sum(dof)]. AfterWorkspacechanges, we started indexing into theCompositionSetobjects ascompset.dof[:sum(dof)]without accounting for state variable offsets. This PR fixes that and introduces tests for correctness.