Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 90.40% 90.68% +0.28%
==========================================
Files 25 26 +1
Lines 2000 2071 +71
==========================================
+ Hits 1808 1878 +70
- Misses 192 193 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation, API integration, tests, and documentation are consistent, with no unresolved blocking findings.
No open issues 🎉
What changed in this PR
Adds Geodesic Flow Kernel (GFK) as a domain-adaptation transformer, integrated into KaleLinear’s public APIs and documentation.
Changes:
- Implements GFK with stable handling of near-zero principal angles.
- Adds kernel, transformation, validation, and public API tests.
- Documents GFK and adds an API map.
| File | Description |
|---|---|
| tests/transformer/test_gfk.py | Tests GFK mathematics, behavior, and validation. |
| tests/test_public_api.py | Checks the GFK public alias. |
| README.md | Introduces GFK, its reference, and the API map. |
| kalelinear/transformer/_gfk.py | Implements the GFK transformer. |
| kalelinear/transformer/__init__.py | Exports GFK. |
| kalelinear/embed.py | Exposes GFK through the embedding API. |
| docs/source/usage.rst | Includes GFK in domain-adaptation usage. |
| docs/source/introduction.rst | Lists GFK among available transformers. |
| docs/source/api_transformers.rst | Adds GFK API documentation. |
| docs/images/api_map.svg | Adds a visual API overview. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add GFK and api map
Status
Ready
Types of changes
docsupdated.