Conversation
The underscore-stripping fix for deactivated modules assumed every host runs a pyobs-core new enough to strip leading underscores from PYOBS_MODULE (f3b20627). Older pyobs-core still tags the raw config name, so hardcoding the new behavior would break log filtering on any host running an older version. _journald_module_tag() now checks the actually-installed pyobs-core version (via the same PYOBS_EXEC-relative pip lookup already used for package management) and picks the matching tagging convention per host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version 1.9.5