pack: return error when no devices match - #2018
Open
giri256 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Giridhar <80974392+giri256@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1130.
pyocd pack findandpyocd pack installcurrently return success when no device matches the requested pattern. This makes failed lookups indistinguishable from successful commands in scripts.The modern subcommands and their deprecated
--find/--installequivalents now return status 1 when the match set is empty. The behavior ofpack updateis unchanged because a metadata refresh can partially succeed, as discussed in the issue.Tests:
pytest test/unit/test_pack_cmd.py -q— 4 passedpytest test/unit -q— 1104 passed, 41 skippedflake8 pyocd test --count --select=E9,F63,F7,F82 --show-source --statistics— 0 errorspython test/import_all.py— 372 modules importedpython -m buildtwine check dist/*— wheel and source archive passedgit diff --check