feat: blocked argument#1698
Open
KelvinChung2000 wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1698 +/- ##
==========================================
- Coverage 99.58% 99.52% -0.06%
==========================================
Files 23 23
Lines 5772 5888 +116
==========================================
+ Hits 5748 5860 +112
- Misses 24 28 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
tleonhardt
requested changes
Jun 25, 2026
| try: | ||
| field_hints = get_type_hints(dc_type, include_extras=True) | ||
| except (NameError, AttributeError, TypeError) as exc: | ||
| raise TypeError( |
Member
There was a problem hiding this comment.
Please add a test to cover this TypeError case
| expanded: list[_ArgparseArgument] = [] | ||
| for f in fields(dc_type): | ||
| if not f.init: | ||
| continue # field(init=False) is not a constructor argument, so it has no command-line value |
Member
There was a problem hiding this comment.
Please add a test to cover this line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1689
close #1690