-
-
Notifications
You must be signed in to change notification settings - Fork 34.9k
gh-152384: pixi-packages: use flags to define variants
#152385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8b5b0c2
gh-152384: pixi-packages: use `flags` to define variants
lucascolley 81c8972
Merge branch 'main' into pixi-flags
hugovk b226f35
tweaks
lucascolley 5cba45c
add news
lucascolley f152ba7
pin to clang 21
lucascolley 18c12e6
remove abi_tag from variant
lucascolley 44c27db
Update Tools/pixi-packages/recipe.yaml
lucascolley a608b30
Update README.md
lucascolley 8af45b3
revisions [skip ci]
lucascolley 2b05522
Update Tools/pixi-packages/README.md
lucascolley 01a12c8
Update Tools/pixi-packages/build.sh
lucascolley 08807bb
down-prioritize non-default variants
lucascolley 330239c
remove `libsanitizer`
lucascolley 036f9a3
add note about bumping clang version
lucascolley d72075b
Update Tools/pixi-packages/build.sh
lucascolley de788e8
Update Tools/pixi-packages/build.sh
lucascolley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
Misc/NEWS.d/next/Tools-Demos/2026-07-10-14-38-31.gh-issue-152384.uaPADM.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| The CPython Pixi packages are now all accessible at the same | ||
| ``Tools/pixi-packages`` subdirectory, rather than at | ||
| ``Tools/pixi-packages/{variant}`` as before. Variants are now selected not | ||
| via subdirectory but via ``flags``; see | ||
| https://pixi.prefix.dev/latest/concepts/package_specifications/#extras-and-flags | ||
| for usage instructions. The ``tsan-freethreading`` variant has been renamed | ||
| to ``tsan_freethreading``, while the ``default``, ``asan``, and | ||
| ``freethreading`` variants retain their previous names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
8 changes: 1 addition & 7 deletions
8
Tools/pixi-packages/asan/pixi.toml → Tools/pixi-packages/pixi.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,9 @@ | ||
| # NOTE: Please always only modify default/pixi.toml and then run clone-recipe.sh to | ||
| # propagate the changes to the other variants. | ||
|
|
||
| [workspace] | ||
| channels = ["https://prefix.dev/conda-forge"] | ||
| platforms = ["linux-64", "linux-aarch64", "osx-64", "osx-arm64"] | ||
| preview = ["pixi-build"] | ||
| requires-pixi = ">=0.66.0" | ||
| requires-pixi = ">=0.72.2" | ||
|
|
||
| [package.build.backend] | ||
| name = "pixi-build-rattler-build" | ||
| version = "*" | ||
|
|
||
| [package.build.config] | ||
| recipe = "../default/recipe.yaml" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
|
lucascolley marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| version: ["3.16"] | ||
| variant: ["default", "asan", "freethreading", "tsan_freethreading"] | ||
|
|
||
| openssl: | ||
| - '3.5' | ||
|
|
||
| # match `.github/workflows/reusable-san.yml` | ||
| c_compiler: | ||
| - clang | ||
| c_compiler_version: | ||
| - 21 | ||
| cxx_compiler: | ||
| - clangxx | ||
| cxx_compiler_version: | ||
| - 21 | ||
|
kumaraditya303 marked this conversation as resolved.
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to remove the
-from this variant name, given that it is invalid in theflagsfield: https://conda.org/learn/ceps/cep-0045#repodata-record-syntaxThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine to me, I think you and @crusaderky are just about the only users of these builds so far for what its worth