use _exit in forked multiproc test workers (#526) - #526
Merged
Merged
Conversation
|
@d4l3k has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122596608. |
kapilsh
approved these changes
Sep 30, 2026
d4l3k
added a commit
to d4l3k/gloo
that referenced
this pull request
Sep 30, 2026
Summary: MultiProcTest children call exit() after fork, which runs static/folly singleton destructors inherited from the parent. In fbcode, ODS InstrumentReader's FunctionScheduler then joins a thread that only existed in the parent, and ASan aborts with "Joining already joined thread", turning the worker's exit code into 1. This breaks tests that check a specific exit status, e.g. TcpLazyPeerExitBeforeFirstIo in pytorch#521 (D116972502). Use _exit() so children skip parent-owned teardown. ___ Differential Revision: D122596608
meta-codesync
Bot
changed the title
d4l3k
force-pushed
the
export-D122596608
branch
from
September 30, 2026 20:26
d1d881e to
eb6ec4f
Compare
Summary: Pull Request resolved: pytorch#526 MultiProcTest children call exit() after fork, which runs static/folly singleton destructors inherited from the parent. In fbcode, ODS InstrumentReader's FunctionScheduler then joins a thread that only existed in the parent, and ASan aborts with "Joining already joined thread", turning the worker's exit code into 1. This breaks tests that check a specific exit status, e.g. TcpLazyPeerExitBeforeFirstIo in pytorch#521 (D116972502). Use _exit() so children skip parent-owned teardown. ___ Differential Revision: D122596608
d4l3k
force-pushed
the
export-D122596608
branch
from
September 30, 2026 20:30
eb6ec4f to
a88afeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
MultiProcTest children call exit() after fork, which runs static/folly singleton destructors inherited from the parent. In fbcode, ODS InstrumentReader's FunctionScheduler then joins a thread that only existed in the parent, and ASan aborts with "Joining already joined thread", turning the worker's exit code into 1. This breaks tests that check a specific exit status, e.g. TcpLazyPeerExitBeforeFirstIo in #521 (D116972502). Use _exit() so children skip parent-owned teardown.
Differential Revision: D122596608