docs(architecture): refine Qt migration, Tauri exit & PWA reuse strategy - #477
docs(architecture): refine Qt migration, Tauri exit & PWA reuse strategy#477qnbs wants to merge 14 commits into
Conversation
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's GuideRefines the native desktop migration strategy docs by adding a detailed Qt-first roadmap revision and tightening the Tauri transitional maintenance policy around #332, emphasizing portable-vs-runtime classification, cross-renderer acceptance criteria, and strict renderer-neutral architecture invariants. Sequence diagram for cross-renderer lifecycle acceptancesequenceDiagram
participant Harness as BenchmarkHarness
participant PWA as PWA
participant Tauri as Tauri
participant Qt as Qt
participant Core as RustCore
Harness->>PWA: run GOLDEN_DESKTOP_LIFECYCLE_332
PWA->>Core: edit_and_autosave
Harness->>PWA: background_and_resume
Harness->>Tauri: run GOLDEN_DESKTOP_LIFECYCLE_332
Tauri->>Core: edit_and_autosave
Harness->>Tauri: background_and_resume
Harness->>Qt: run GOLDEN_DESKTOP_LIFECYCLE_332
Qt->>Core: edit_and_autosave
Harness->>Qt: background_and_resume
Harness->>Harness: compare latency_memory_and_lifecycle_results
Flow diagram for Tauri evidence exit and Qt transfer readinessflowchart TD
S[#332 observed symptom] --> C{Portable or runtime-specific?}
C -->|Data, security, app/Core, or portable memory defect| F[FIX or DEFER-TO-CORE]
C -->|Narrow adapter defect| A[FIX or MITIGATE]
C -->|Runtime, compositor, driver, or WebProcess correlation| E[Bounded evidence]
C -->|Unknown ownership| I[Instrument until ownership narrows]
E --> X[G1.5 Tauri Evidence Exit]
I --> C
X --> H[Reusable lifecycle and benchmark scenarios]
H --> Q[G2.5 Qt Renderer Differential Gate]
Q -->|Pass| M[Proceed with broad Qt migration]
Q -->|Fail| R[Pause Qt investment and review architecture]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
codeant-ai
Bot
added
the
size:XXL
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully refines the desktop migration strategy documentation without introducing any blocking issues. The changes are documentation-only and appropriately scoped:
Key Additions:
- Comprehensive Desktop Migration Roadmap Revision 3 with clear gates, waves, and decision criteria
- Enhanced Tauri Transitional Maintenance policy with portable-vs-runtime classification
- Formal investment gates (G1.5, G2.5) and Wave 2.5 for evidence-based migration
- Cross-renderer benchmark framework and GOLDEN-DESKTOP-LIFECYCLE-332 acceptance scenario
Governance Alignment:
The PR correctly declares no changes to authority, runtime code, CI requirements, or security boundaries. The documentation strengthens architectural invariants around the DesktopPlatform boundary and renderer-neutral Core.
Recommendation: Approved for merge after normal CI/documentation checks pass.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 111 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Warning Your free Security trial is over. An organization admin can activate billing to continue. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b82d081176
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Review reconciliation on head
No production/native runtime authority changed. CI/CD and CodeQL are running on the corrected head. This PR remains intentionally open and must not be merged until the separate in-progress VS Code/Codex execution has fully completed and the branch is reconciled against the resulting |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f833bf6af8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
removed
the
size:XXL
codeant-ai
Bot
added
the
size:XXL
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 169bcb6543
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Commit-signing note — 2026-08-24The architecture/governance refinements added in this pass were committed directly through the GitHub connector and are intentionally treated as temporary unsigned commits on the existing PR branch. Before merge, the branch owner plans to rewrite/rebase this commit stack locally through Codex CLI / VS Code and recreate the affected commits with the repository's normal verified signing configuration. Therefore:
|
Review-correction reconciliation — 2026-08-24All currently reported inline review findings have now been reconciled and the threads resolved. Corrections include:
The current commits remain temporary unsigned connector-created commits per the earlier signing note. After the planned signed local rewrite, all CI/CodeQL/signature/review evidence must be regenerated against the rewritten head SHA. |
qnbs
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f010dae61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
Refines the Qt-first desktop migration strategy using the accumulated #332 packaged Linux evidence and now codifies the cross-cutting reuse/ownership discipline required to execute the migration and the first-class PWA program without parallel product architectures.
This remains an architecture/governance PR. It changes no shipped runtime authority and introduces no production Qt UI.
What changes
Revision-3 native migration refinement
docs/native/DESKTOP-MIGRATION-ROADMAP-REV3.mdas the normative Revision-3 strategic refinement to ADR-0021 / the canonical Qt-first roadmap for the subjects it explicitly narrows or strengthens;TAURI-TRANSITIONAL-MAINTENANCE.mdwith portable-vs-runtime classification, memory classification, stop-loss rules, cross-renderer acceptance evidence, clean-process-tree requirements, and a formal Qt handoff policy;Cross-cutting architecture reuse / ownership governance
docs/architecture/ARCHITECTURE-REUSE-OWNERSHIP.mdas a governance companion, not another roadmap;ONE PRODUCT MODEL / ONE VERSIONED PROJECT TRUTH / ONE AUTHORITY PER SEMANTIC CAPABILITY;Mechanical enforcement
scripts/check-native-readiness.mjsnow also verifies that the reuse/ownership policy retains critical invariants, including:Repository issue reconciliation performed alongside this refinement
The related GitHub issues now carry maintainer-level architecture refinements so implementation agents do not reinterpret the umbrella work as greenfield:
docs/PWA-AUDIT.mdevolution;ExternalLaunchIntentand permits only a bounded Capture Inbox as genuinely new domain capability;worldscript-autosaveBackground Sync semantics;Non-goals
Governance
Validation expected
Closes no issue.
Summary by Sourcery
Codify the refined Qt migration and first-class PWA strategy around shared semantic evidence, explicit ownership, and reuse of existing architectural authorities.
Enhancements:
CI:
Documentation: