fix(console): auto-collapse sidebars on narrow viewports#582
Open
midaksh wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hey @midaksh, I think this is a great start with the breakpoints!
Let me know if you need any help! |
Author
@emrberk This was my actual idea to start with this approach, but since it was a pre-existing logic for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part B of #574: when the viewport shrinks, auto-collapse the left and right sidebars so the notebook stays the primary, usable surface.
Stacks on #581 (Part A).
Changes
src/hooks/useScreenSize.tsxmd(1024px) andlg(1280px) breakpoints alongside the existingsm(767px)shallowEqualupdate pattern assmsrc/scenes/Console/index.tsxAI/ table details): hide below 1280px (!lg) — larger footprint (470px min), collapses first!md) — in addition to existing!smat 767pxproportionalLayout={false}on the outerAllotmentso the AI panel restores its savedpreferredSizeafter resize instead of expanding to max widthBehaviour
sm)Panel open/close state (Redux
activeSidebar, localStorageleftPanelState) is not mutated — panels restore when the viewport widens past the threshold.Out of scope
Mobile icon visibility (datasource hidden at
sm) – pre-existingDrawer/overlay for panel toggles on very narrow viewports – follow-up if desired
Closes: Notebook layout: responsive chart/grid/cell action bars (overflow menu) + sidebar collapse that keeps focus on the notebook #574 (Part B)
Stacked on: feat: redesign notebook cell toolbar with view toggles and auto-refresh intervals #581