chore(argocd-understack): remove unnecessary ref in multi-source app - #2218
Merged
Conversation
These refs are never dereferenced: no source in these Applications uses $understack/ or $deploy/ in helm.valueFiles or anywhere else. This ref causes ArgoCD to crash with a runtime exception due to argoproj/argo-cd#25460 and the fix not being backported to any release branch yet. 8f9e2d7 and 92ee95e removed these from the single-source Applications. This covers the multi-source ones that were missed, including the openstack-sync-plugins Application added in #2205, and drops the ref-only source in the snmp-exporter Application that nothing referenced. The openstack-sync-operator Application keeps both of its refs since its helm.valueFiles dereferences each one. Rendering charts/argocd-understack against both ci/ values files with the affected components enabled produces no change other than the removed ref lines. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
haseebsyed12
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast follow to #2205, addressing item 3 from the pass-4 review.
These
ref:fields are never dereferenced — no source in these Applications uses$understack/or$deploy/inhelm.valueFilesor anywhere else. Per 8f9e2d7 and 92ee95e, an unnecessary ref causes ArgoCD to crash with a runtime exception due to argoproj/argo-cd#25460, and that fix still has not been backported to any release branch.Those two commits only covered the single-source Applications. This covers the multi-source ones that were missed:
application-argo-events.yamlref: understack,ref: deployapplication-argo-events-workflows.yamlref: understack,ref: deployapplication-global-workflows.yamlref: understack,ref: deployapplication-openstack-sync-plugins.yamlref: understack,ref: deployapplication-external-secrets.yamlref: understackapplication-openstack.yamlref: understackapplication-snmp-exporter.yaml- ref: understacksourceapplication-openstack.yamlkeepsref: deploy, which itsvalueFilesdereferences.application-snmp-exporter.yamlhad a source consisting only ofref: understackwith nopath, referenced by nothing, so the source is dropped rather than just the ref.application-openstack-sync-operator.yamlkeeps both of its refs since itshelm.valueFilesdereferences each one.Verification
Every
ref: understack/ref: deployin the chart was checked against whether its Application dereferences$understack//$deploy/. After this change no unused refs remain, and no Application references a ref it no longer declares.Rendering
charts/argocd-understackagainst bothci/example.yamlandci/example-global.yaml, with all affected components enabled, gives 13 lines removed and 0 added versusmain— only theref:lines and the dead snmp-exporter source. No other manifest changes.🤖 Generated with Claude Code