Anchor the push-number rewrite to the build directory - #17
Merged
Merged
Conversation
DrDr scrubs push-specific paths from captured output, so that a log changes only when the test's behavior does. It replaced the push number as a bare string, so it also rewrote every other occurrence of those digits. On push 73506 `raco pkg show` therefore reported expeditor as changed, because its checksum ends in that number: 65e20a410bdc5f09c0682a1bb57cac2b68d73506 65e20a410bdc5f09c0682a1bb57cac2b68d<current-rev> frtime did the same on push 73507, and any push whose number appears in an installed package's checksum will do it again. Replace the build directory joined with the push number instead; output for real build paths does not change.
samth
force-pushed
the
anchor-rev-scrub
branch
from
September 23, 2026 20:15
d052217 to
9c1b2a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DrDr scrubs push-specific paths from captured output, so that a log
changes only when the test's behavior does. It replaced the push number
as a bare string, so it also rewrote every other occurrence of those
digits. On push 73506
raco pkg showtherefore reported expeditor aschanged, because its checksum ends in that number:
65e20a410bdc5f09c0682a1bb57cac2b68d73506
65e20a410bdc5f09c0682a1bb57cac2b68d
frtime did the same on push 73507, and any push whose number appears in
an installed package's checksum will do it again. Replace the build
directory joined with the push number instead; output for real build
paths does not change.