Avoid an flabs call in flonums-between - #120
Merged
Merged
Conversation
Member
|
FWIW, it seems wrong that the |
Collaborator
Author
|
Good point, but either way this seems like a good change… Worst case it’s only a (small) perf and simplicity improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel dumb I didn't see this the first time! The
flonums-betweenfunction is optimized to allocate less, but it still callsflabsto normalize positive and negative zero before extracting the high and low words of a flonum. Andflabsallocates because Chez flonums are heap-allocated. But we don't need to callflabs! We can just not extract the sign bit!