Optimize _blank? - #622
Open
moberegger wants to merge 2 commits into
Open
Conversation
moberegger
commented
Aug 17, 2026
Comment on lines
-5
to
-8
| def ==(other) | ||
| super || Blank === other | ||
| end | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Not necessary for the optimization, but figured I'd remove it since it is no longer running in the gem.
I suppose it's possible the a user is doing something with Jbuilder::Blank directly that may require this, but I believe this class was intended to be an implementation detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches
_blank?fromBLANK == valuetoBlank === value.Originally
_blank?did a Ruby-level dispatch toBlank#==, which itself callssuper(for an identity check) and thenBlank === other. We can short circuit this to simply beBlank === other. This gives us the same result for less work becauseBlank#==would always returntruefor anyBlankinstance. We don't actually need to an identity check.Below is an IPS benchmark against a simple builder that exercises
_blanka few times.