Type the server's NoLeaderException instead of a misspelled key - #310
Merged
Merged
Conversation
The map was keyed on NoLoaderException, which the server never sends, so a real no-leader failure reached callers as a plain RavenException. The old name stays importable as an alias.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server sends
NoLeaderException. The map was keyed onNoLoaderException, a name the server never sends, so a real no-leader failure reached callers as a plainRavenException.The class is renamed to match, with the old name kept as an alias so existing imports and
exceptclauses keep working:Three tests in
ravendb/tests/issue_tests/test_exception_dispatcher.py, no server needed.Found while syncing the test driver with C#, where teardown has to swallow a no-leader failure and could not catch it by type.