Flush NativeAnimated batch via microtask instead of set/clearImmediate#57209
Open
zeyap wants to merge 1 commit into
Open
Flush NativeAnimated batch via microtask instead of set/clearImmediate#57209zeyap wants to merge 1 commit into
zeyap wants to merge 1 commit into
Conversation
Summary: We used `setImmediate` to schedule the operations in order to use microtasks queue (given the immediate shim used in RN). But jest tests treat setImmediate callback as macrotask like setTimeout (which is browser-aligned behavior). This makes it difficult to test the change introduced by featureflag `animatedShouldDebounceQueueFlush` and `cxxNativeAnimatedEnabled` Differential Revision: D108640934
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108640934. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: We used
setImmediateto schedule the operations in order to use microtasks queue (given the immediate shim used in RN). But jest tests treat setImmediate callback as macrotask like setTimeout (which is browser-aligned behavior). This makes it difficult to test the change introduced by featureflaganimatedShouldDebounceQueueFlushandcxxNativeAnimatedEnabledDifferential Revision: D108640934