remove useNativeDriver under featureflag animatedForceNativeDriver#57211
Open
zeyap wants to merge 1 commit into
Open
remove useNativeDriver under featureflag animatedForceNativeDriver#57211zeyap wants to merge 1 commit into
useNativeDriver under featureflag animatedForceNativeDriver#57211zeyap wants to merge 1 commit into
Conversation
Summary: ## Changelog: [General] [Added] - remove `useNativeDriver` under featureflag animatedForceNativeDriver When `animatedForceNativeDriver` is enabled, it forces `useNativeDriver` to `true` for all Animated animations and events, overriding the config (explicit `false` set by user will be no-op). Has no effect unless the shared animated backend is enabled, which is required to support native driver for all props. Also using this flag to gate the js animation logic that could be cleaned up when this path is fully working. Differential Revision: D108193641
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108193641. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General] [Added] - remove
useNativeDriverunder featureflag animatedForceNativeDriverWhen
animatedForceNativeDriveris enabled, it forcesuseNativeDrivertotruefor all Animated animations and events, overriding the config (explicitfalseset by user will be no-op). Has no effect unless the shared animated backend is enabled, which is required to support native driver for all props.Also using this flag to gate the js animation logic that could be cleaned up when this path is fully working.
Differential Revision: D108193641