Fix asyncArrayBufferBorrowNativeBackedTest unconditional skip on Hermes#57212
Closed
christophpurrer wants to merge 1 commit into
Closed
Fix asyncArrayBufferBorrowNativeBackedTest unconditional skip on Hermes#57212christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
Summary: ## Changelog: [General][Fixed] Fix asyncArrayBufferBorrowNativeBackedTest unconditional skip on Hermes On runtimes that don't implement `tryGetMutableBuffer` (e.g. Hermes / Android-32bit), `asyncArrayBufferBorrowNativeBackedTest` always called `GTEST_SKIP()`, which surfaced as a perpetually-skipped test in CI. Replace the skip with `EXPECT_JSI_THROW(AsyncArrayBuffer::borrow(...))`. On runtimes without `tryGetMutableBuffer`, `borrow` is documented to throw because there is no native `MutableBuffer` to hand back, so this is the meaningful behavior to assert. On runtimes that do implement `tryGetMutableBuffer`, the existing zero-copy assertions are unchanged. ___ Differential Revision: D108657073
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108657073. |
|
This pull request has been merged in 9d54391. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General][Fixed] Fix asyncArrayBufferBorrowNativeBackedTest unconditional skip on Hermes
On runtimes that don't implement
tryGetMutableBuffer(e.g. Hermes / Android-32bit),asyncArrayBufferBorrowNativeBackedTestalways calledGTEST_SKIP(), which surfaced as a perpetually-skipped test in CI.Replace the skip with
EXPECT_JSI_THROW(AsyncArrayBuffer::borrow(...)). On runtimes withouttryGetMutableBuffer,borrowis documented to throw because there is no nativeMutableBufferto hand back, so this is the meaningful behavior to assert. On runtimes that do implementtryGetMutableBuffer, the existing zero-copy assertions are unchanged.Differential Revision: D108657073