Expand silk-native with visual primitives and forms - #16
Conversation
Ship Surface through Progress plus Input/Textarea/Field/Checkbox/Switch/RadioGroup on the same silk-core recipes as web, with RNW a11y compat, fixtures, and gates. Slider stays deferred to avoid forking the shared array-valued contract. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 013eedd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…n first paint. Keep RadioGroup item spacing in the style mapper, leave disabled Switch thumbs on surface, and seed reduce-motion from matchMedia so motion never flashes before the OS preference resolves. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ce-motion probe failures. Storybook's state control now reseeds checkbox/field defaults without a remount race, and AccessibilityInfo errors fall back to allowing motion instead of sticking on the optimistic reduced-motion default. Co-authored-by: Cursor <cursoragent@cursor.com>
Apply fixed size to an inner View and row layout on Pressable, matching RadioGroup.Item so labels are not clipped by the checkbox dimensions. Co-authored-by: Cursor <cursoragent@cursor.com>
Custom Label/Description/Error nativeIDs were ignored, so group controls could point accessibilityLabelledBy at the generated id instead of the slot view. Co-authored-by: Cursor <cursoragent@cursor.com>
The children-beside-box fix pushed isolated Checkbox to 2919 B; give modest headroom so CI tracks real regressions. Co-authored-by: Cursor <cursoragent@cursor.com>
…eselect. Keep descriptions/errors under the label in horizontal fields, derive Switch thumb travel from measured track width, and match web by not re-emitting RadioGroup changes for the active item. Co-authored-by: Cursor <cursoragent@cursor.com>
…lves. On RNW, keep prefers-reduced-motion as the source of truth so Storybook and tests do not re-enable motion when AccessibilityInfo disagrees. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the legacy MediaQueryList listener path and assert AccessibilityInfo is skipped when matchMedia is available. Co-authored-by: Cursor <cursoragent@cursor.com>
| }, | ||
| ]} | ||
| /> | ||
| ) : null} |
There was a problem hiding this comment.
Progress bar empty until layout
Low Severity
Determinate Progress only mounts the fill indicator when trackWidth > 0, and width comes solely from onLayout. Until layout runs, users see an empty track even when value is set (e.g. 72%), so completeness feedback is missing on the first frame(s).
Reviewed by Cursor Bugbot for commit a6f4e1a. Configure here.
…ce until Reduce Motion is confirmed. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 013eedd. Configure here.
| style={[mapped, style]} | ||
| > | ||
| {children} | ||
| </RNText> |
There was a problem hiding this comment.
Native heading level not exposed
Medium Severity
Native Heading sets accessibilityRole="header" and an RNW-only aria-level, but never sets iOS accessibilityLevel from the level recipe prop. VoiceOver on device therefore cannot reflect the intended heading hierarchy (e.g. level 2 vs 3), unlike web’s semantic h1–h6 tags.
Reviewed by Cursor Bugbot for commit 013eedd. Configure here.
1 participant
Summary
@reactive/silk-nativewith visual primitives (Surface,Card,Heading,Badge,Separator,Avatar,StatusDot,Skeleton,Spinner,Progress) and forms (Input,Textarea,Field,Checkbox,Switch,RadioGroup) on the same silk-core recipes as web.useReducedMotion, RNW a11y compat helpers, and Field wiring that mirrors the web contract.Slider(documented) so the array-valued multi-thumb contract is not forked; updates docs (NativeSettingsForm fixture + stories), example app, perf budgets, and packed-consumer check.Test plan
yarn workspace @reactive/silk-native test(59)yarn workspace @reactive/silk-docs test(376)node scripts/perf-budgets.mjsnode scripts/packed-consumer-check.mjsyarn workspace @reactive/silk-native-example testapps/native-example/README.md(shadows, spinner, switch, TalkBack/VoiceOver, RTL)Made with Cursor