Repository navigation
docs(samples): embed every sample video in the README's contents table - #130
Merged
Merged
Conversation
GitHub embeds a video only when a table cell holds a single attachment link, so the sampler and showcase rows (two videos each) showed plain links. They are split into one row per script, and the cinematic row gets its reel from PR #129 instead of "attached to the PR". All eleven videos now embed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
samples/opus55-motion/README.mdの目次の表で、見本の動画 11 本をすべて再生画面として埋め込みます。sampler/とshowcase/の行を台本ごとの 2 行に分け、cinematic/の行に PR feat(samples): add reusable cinematic shots drawn in three.js #129 に添付したリールを入れたcinematic/の動画は PR feat(samples): add reusable cinematic shots drawn in three.js #129 のものであることと、行を分けた理由を書き足したItems to Confirm / Review
sampler/とshowcase/が 2 行ずつになった。1 行目の「中身」はそのまま、2 行目は「L1 の縦型」「Shorts のハイテンポ」としたUser Prompt
samples/opus55-motionの動画をリンクではなく埋め込みにしたい確かめたこと
gh api markdown、gfm、context は receptron/presentations）で確かめた: リンク 1 本だけのセルは<video>になり、リンク 2 本、素の URL 2 本の<br>区切り、リンク 2 本の<br>区切りはどれもリンクのままだった<video>が 11 個（sampler 2・showcase 2・ideas 系 6・cinematic 1）🤖 Generated with Claude Code
work in mulmocast-cli