Getting ready for KMP - #17
Open
Blatzar wants to merge 4 commits into
Open
Conversation
added 2 commits
July 17, 2026 21:03
Blatzar
commented
Jul 19, 2026
| """.trimIndent() | ||
| targetFile.appendText(initText) | ||
|
|
||
| // Load a Nuvio bridge to export the necessary Nuvio methods |
Contributor
Author
There was a problem hiding this comment.
Commented out until the CloudStream library contains the necessary Nuvio bridge.
Blatzar
commented
Jul 19, 2026
| } | ||
|
|
||
| @ExperimentalMultiplatform | ||
| fun KotlinMultiplatformExtension.nuvio() { |
Contributor
Author
There was a problem hiding this comment.
Extension maintainers will be able to do:
cloudstream {
multiplatform {
nuvio()
}
// Rest of normal cloudstream plugin config
}The idea with early Nuvio support is to trial the experimental JS experience before we implement a JS engine in CloudStream.
Blatzar
commented
Jul 19, 2026
|
|
||
| val pluginClassName = pluginClassFile.map { it.asFile.readText() }.get() | ||
|
|
||
| // Always load the plugin when JS file is loaded. |
Contributor
Author
There was a problem hiding this comment.
This will need all JS plugins to have a JsExport annotation in addition to their CloudstreamPlugin annotation. This is unavoidable without custom KSP processors.
|
Can we have something for skystream too @Blatzar ? |
Contributor
Author
|
Yes, the plan is to support as many apps as possible with the least amount of hassle for extension developers. Nuvio is the first target due to its simple API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can compile KMP projects and normal projects. Features a new CompilePluginJsTask to compile and output js files.
From my testing it does not contain any breaking changes.
Future changes may be needed for automatic JsExports annotations.