[TypeDeclarationDocblocks] Skip docblock already defined in parent on DocblockVarArrayFromPropertyDefaultsRector#8085
Open
samsonasik wants to merge 4 commits into
Open
[TypeDeclarationDocblocks] Skip docblock already defined in parent on DocblockVarArrayFromPropertyDefaultsRector#8085samsonasik wants to merge 4 commits into
samsonasik wants to merge 4 commits into
Conversation
…n DocblockVarArrayFromPropertyDefaultsRector
…n DocblockVarArrayFromPropertyDefaultsRector
samsonasik
changed the title
Member
Author
|
Fixed 🎉 /cc @BackEndTea |
Member
Author
|
@TomasVotruba ready 👍 |
| return false; | ||
| } | ||
|
|
||
| $classReflection = $this->reflectionResolver->resolveClassReflection($class); |
Member
There was a problem hiding this comment.
Here, the $scope can be used instead. I prefer it over service, as we're closer to PHPStan logic.
$scope = ScopeFetcher::fetch($classMethod);
$classReflection = $scope->getClassReflection();
if (! $classReflection instanceof ClassReflection) {
return null;
}
$parentClassReflection = $classReflection->getParentClass();
if (! $parentClassReflection instanceof ClassReflection) {
return null;
}
Member
Author
There was a problem hiding this comment.
updated to use ScopeFetcher, the loop is still needed since it lookup parent that has the docblock, if parent redefine on grand parent and only grand parent that has docblock, that follow that.
Member
Author
|
@TomasVotruba ready 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9779