Skip to content

bundled-tools-can-execute: avoid 'echo | grep -q' SIGPIPE with pipefail. #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmds merged 1 commit into from
Oct 14, 2026
Merged

bundled-tools-can-execute: avoid 'echo | grep -q' SIGPIPE with pipefail. #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundled-tools-can-execute/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ for tool in "${!tools[@]}"; do
# Ignore the exit code because 'dotnet user-secrets' has a non-zero exit for '--help'.
output=$(dotnet "${tool}" --help 2>&1) || true

if echo "${output}" | grep -q "${expected}"; then
if grep -q "${expected}" <<< "${output}"; then
echo "PASS: dotnet ${tool} --help"
else
echo "FAIL: dotnet ${tool} --help did not contain '${expected}'"
Expand Down
4 changes: 1 addition & 3 deletions use-current-runtime/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ PORTABLE_RID="$(../runtime-id --portable)"

DOTNET_BUILD_OUTPUT=$(dotnet build --use-current-runtime)

# grep -q can exit early, making the other proceses in the pipe report a
# SIGPIPE, so consume the rest of the output with cat to avoid the SIGPIPE
if echo "$DOTNET_BUILD_OUTPUT" | { grep -q "RuntimeIdentifier is $PORTABLE_RID"; cat >/dev/null; } then
if grep -q "RuntimeIdentifier is $PORTABLE_RID" <<< "$DOTNET_BUILD_OUTPUT"; then
echo "PASS: --use-current-runtime uses portable rid."
else
echo "FAIL: --use-current-runtime does not use portable rid."
Expand Down
Loading