Optimize FindQuery.update() with partial writes - #843
Open
lh0156 wants to merge 2 commits into
Open
Conversation
lh0156
marked this pull request as ready for review
July 30, 2026 09:12
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 408cc9f. Configure here.
| and hasattr(candidate, "model_fields") | ||
| ), | ||
| None, | ||
| ) |
There was a problem hiding this comment.
Nested model detection ignores Pydantic v1 attribute name
Low Severity
In _get_update_field, the field lookup at the top of the loop correctly falls back to __fields__ for Pydantic v1, but the nested model detection on line 2041 only checks hasattr(candidate, "model_fields"). Pydantic v1 models use __fields__ instead of model_fields, so nested update paths (e.g., address__city) will always fail with a QuerySyntaxError on v1, even when the path is valid.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 408cc9f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Implements #777 by updating matching records without materializing full Pydantic models.
What changed
FT.SEARCH ... NOCONTENTto collect matching keys page by page.HSETmappings forHashModel.JSON.SETcommands forJsonModel, including nested__paths.use_transactionflag and returns the number of updated records.Testing
pytest -q tests --ignore tests/test_benchmarks.py: 265 passed.pytest -q tests/test_hash_model.py tests/test_json_model.py: 147 passed.ruff checkandruff format --checkon changed source/tests.python -m compileall -q aredis_om tests.bandit -q -r aredis_om/model/model.py -s B608.Redis Stack was run locally via Docker Compose for the integration tests; benchmark tests were excluded from the full run.
Note
Medium Risk
Bulk updates change execution semantics (no per-instance save/load) and touch core query/update paths for both Hash and JSON models, though behavior is covered by new tests and mirrors save encoding.
Overview
FindQuery.update()no longer loads full documents or callssave()per match. It validates and serializes kwargs once (Pydantic constraints plus existing Hash/JSON storage encoding), paginatesFT.SEARCHwithNOCONTENTto collect keys (ignoring.only()projections), then applies updates in a pipeline:HSETmappings forHashModel, path-levelJSON.SETforJsonModel(including__nested paths). It returns the number of updated keys and still honorsuse_transaction.FindQuery.copy()now preservesknnin query state. Docs note the new return value; tests cover validation-before-search, pagination, and Hash vs JSON update paths.Reviewed by Cursor Bugbot for commit 408cc9f. Bugbot is set up for automated code reviews on this repo. Configure here.