ci: add windows-latest to test matrix (P1 prevention) - #9
Merged
Conversation
Expand the test job from Linux-only to a 2-D OS x Python matrix (ubuntu-latest, windows-latest) in both test.yml and publish.yml so CI proves the suite passes on Windows on every PR and publish. Linux-only CI is what let the auth-bypass ship: the old secp256k1 dependency built on Linux but failed on Windows, and CI never noticed. The backend is now coincurve (prebuilt wheels for all platforms), so Windows works — verified locally: 191 passed on Python 3.12/win32. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CYXrdWWjKo5AyGqFAfrdgK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This SDK's CI ran Linux-only, and that gap is what let the auth-bypass ship: the old
secp256k1dependency built fine on Linux but failed to install on Windows, and CI never noticed. The backend is nowcoincurve(ships prebuilt wheels for all platforms), so Windows should work — this change proves it on every PR and prevents the class of regression from recurring.What changed
Converted the
testjob in bothtest.ymlandpublish.ymlfrom a 1-D Python-version matrix onubuntu-latestto a 2-D OS × Python matrix:pip install -e ".[dev]"andpython -m pytest tests/ -vare both cross-platform (no bash-only shell steps in the test job).publishjob staysubuntu-latest(it has bash-specific steps and is not part of the test matrix — untouched).Local Windows verification
Ran the exact CI leg locally on Windows (Python 3.12, win32) in a clean venv:
pip install -e ".[dev]"succeeded —coincurveinstalled from a prebuilt wheel, no native build toolchain needed.python -m pytest: 191 passed (matches the Linux baseline of 191, no failures).🤖 Generated with Claude Code
https://claude.ai/code/session_01CYXrdWWjKo5AyGqFAfrdgK