Skip to content

chore(cli): use @types/cardinal and remove ambient declaration (#7589) - #7639

Open
cooldude698 wants to merge 1 commit into
refinedev:mainfrom
cooldude698:chore/cli-cardinal-types
Open

cooldude698 wants to merge 1 commit into
refinedev:mainfrom
cooldude698:chore/cli-cardinal-types

Conversation

@cooldude698

@cooldude698 cooldude698 commented Oct 24, 2026 •

Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

@refinedev/cli currently uses cardinal@^2.1.1 and maintains a custom ambient type declaration file at packages/cli/src/definitions/cardinal.d.ts because types were historically not bundled with Cardinal.

What is the new behavior?

  • Replaced the custom local ambient declaration cardinal.d.ts with the official DefinitelyTyped package @types/cardinal added to devDependencies.
  • Added a unit test suite for renderCodeMarkdown verifying title extraction from comments, box rendering, and fallback error handling.
  • Verified TypeScript declaration builds and packaging (attw all green).

fixes #7589

Notes for reviewers

None.

@changeset-bot

changeset-bot Bot commented Oct 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7a51d69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@refinedev/cli Patch
@refinedev/devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate maintained Cardinal types in @refinedev/cli

1 participant