Repository navigation
Conversation
|
Author
|
Hi @DoguhanOzgurAkca @BatuhanW, could one of you take a look when you have a moment? This fixes #7640. It's a docs-only change, so I haven't added a changeset. Happy to adjust anything. Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
documentationpackage is changed)What is the current behavior?
The "Logging In & Out" tutorial (and the React Router navigation tutorial) destructure
isPendingfrom a nestedmutationobject:In current
@refinedev/core,useLoginanduseLogoutreturn{ ...mutation }, so there is nomutationproperty and the snippet fails.What is the new behavior?
The snippets read
isPendingat the top level, which matches the hook source and the tutorial's own sandpack files:Files updated:
documentation/tutorial/authentication/logging-in-out/index.md(useLoginanduseLogout)documentation/tutorial/routing/navigation/react-router/index.md(useLogout)documentation/tutorial/routing/navigation/react-router/sandpack.tsx(useLogout)Closes #7640
Notes for reviewers
useUpdateexamples that usemutation: { isPending }were left as they are. That hook does return a nestedmutationobject (seepackages/core/src/hooks/data/useUpdate.ts, which returns{ mutation: mutationResult, mutate, mutateAsync, overtime }).