Skip to content

perf: implement component and image lazy loading (#1382) - #1386

Closed
basantnema31 wants to merge 1 commit into
reframe-oss:mainfrom
basantnema31:perf/lazy-loading-1382
Closed

basantnema31 wants to merge 1 commit into
reframe-oss:mainfrom
basantnema31:perf/lazy-loading-1382

Conversation

@basantnema31

Copy link
Copy Markdown

Fixes #1382. Implemented dynamic imports for VideoEditor and its heavy subcomponents (ExportOverlay, LottiePlayer, etc) to improve load time and bundle size.

@vercel

vercel Bot commented May 29, 2026

Copy link
Copy Markdown

@basantnema31 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @basantnema31!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix labels May 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @basantnema31

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@basantnema31

Copy link
Copy Markdown
Author

Hi! Just a heads up that I'm still actively working on this PR. The implementation is complete — lazy loading has been applied to VideoEditor and all its heavy subcomponents (ExportOverlay, LottiePlayer, etc.) using dynamic imports to improve initial load time and bundle size.

The only pending item is the Vercel preview deployment which requires maintainer authorization. Could a maintainer please authorize the Vercel deployment when they get a chance? Happy to make any additional changes based on review feedback. Thank you! 🙏

@magic-peach magic-peach added the status:awaiting-review Clean PR waiting on a maintainer, not the author label Aug 14, 2026
@magic-peach

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Another open PR (#1564: perf: implement lazy loading and bundle splitting (resolves #1382)) tackles the same issue and is a bit further along (cleaner CI / no merge conflicts), so I'm consolidating there to keep review focused in one place. Closing this one — no reflection on the work itself, just avoiding split review across duplicates. Feel free to bring anything over to #1564 if it adds something that one doesn't have yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Beginner level - 20 pts status:awaiting-review Clean PR waiting on a maintainer, not the author type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Performance] Optimize Application Load Time by Implementing Lazy Loading and Image Optimization

2 participants