Conversation
|
@YAM1234-B is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
👋 Thanks for your PR, @YAM1234-B!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
✅ PR Format Check Passed — @YAM1234-BBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
|
Thanks for the contribution! Another open PR (#1741: feat: add data-testid attributes to key UI elements for automated testing) tackles the same issue and is a bit further along (cleaner CI / no merge conflicts), so I'm consolidating there to keep review focused in one place. Closing this one — no reflection on the work itself, just avoiding split review across duplicates. Feel free to bring anything over to #1741 if it adds something that one doesn't have yet! |
Overview
Resolves #56
This PR adds
data-testidattributes to key UI elements across the component files to make the codebase ready for automated E2E testing (Playwright / Cypress) and component integration testing (React Testing Library).Changes
Added
data-testidattributes to the following elements without introducing any visual or functional modifications:data-testidvalueFileUpload.tsxfile-upload-zoneVideoEditor.tsxexport-buttonExportOverlay.tsxexport-progressDownloadResult.tsxdownload-buttonDownloadResult.tsxreset-buttonExportSettings.tsxquality-sliderAudioSpeedControl.tsxspeed-sliderVerification
npm run lintsuccessfully.npm run test runto run the Vitest suite. All 115 tests passed without regressions.Checklist
data-testidattributes