Skip to content

test: add data-testid attributes to key UI elements for automated testing #56 - #1525

Closed
YAM1234-B wants to merge 1 commit into
reframe-oss:mainfrom
YAM1234-B:issue-56-data-testid
Closed

YAM1234-B wants to merge 1 commit into
reframe-oss:mainfrom
YAM1234-B:issue-56-data-testid

Conversation

@YAM1234-B

Copy link
Copy Markdown

Overview

Resolves #56

This PR adds data-testid attributes to key UI elements across the component files to make the codebase ready for automated E2E testing (Playwright / Cypress) and component integration testing (React Testing Library).

Changes

Added data-testid attributes to the following elements without introducing any visual or functional modifications:

Component Element / Role data-testid value
FileUpload.tsx Drag & Drop Zone Container file-upload-zone
VideoEditor.tsx Main Export Button export-button
ExportOverlay.tsx Export Progress Bar export-progress
DownloadResult.tsx Download Video Link download-button
DownloadResult.tsx Restart / "New" Button reset-button
ExportSettings.tsx CRF Quality Slider Input quality-slider
AudioSpeedControl.tsx Speed Playback Slider Input speed-slider

Verification

  • Linting: Ran npm run lint successfully.
  • Tests: Ran npm run test run to run the Vitest suite. All 115 tests passed without regressions.

Checklist

  • All listed elements have correct data-testid attributes
  • Tested locally and confirmed no visual/functional regressions

@vercel

vercel Bot commented Jun 3, 2026

Copy link
Copy Markdown

@YAM1234-B is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @YAM1234-B!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @YAM1234-B

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:design UI/UX design type:performance Performance type:testing Testing labels Jun 3, 2026
@magic-peach magic-peach added the status:awaiting-review Clean PR waiting on a maintainer, not the author label Aug 14, 2026
@magic-peach

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Another open PR (#1741: feat: add data-testid attributes to key UI elements for automated testing) tackles the same issue and is a bit further along (cleaner CI / no merge conflicts), so I'm consolidating there to keep review focused in one place. Closing this one — no reflection on the work itself, just avoiding split review across duplicates. Feel free to bring anything over to #1741 if it adds something that one doesn't have yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Beginner level - 20 pts status:awaiting-review Clean PR waiting on a maintainer, not the author type:design UI/UX design type:performance Performance type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue] Add data-testid attributes to key UI elements

2 participants