feat: add data-testid attributes to key UI elements - #1710
Youngmaster0304 wants to merge 3 commits into
Conversation
Changed the h1 element in the header to a span element to ensure there is only one h1 per page (the main REFRAME title in VideoEditor). Fixes reframe-oss#69 Contributor: Abhinav Jha (@Youngmaster0304) Email: abhinavjha0304@gmail.com GSSoC 2026 Participant
Added title attributes to quick action buttons (Instagram Reels, TikTok, YouTube Short, YouTube, Twitter/X) showing exact dimensions. Fixes reframe-oss#71 Contributor: Abhinav Jha (@Youngmaster0304) Email: abhinavjha0304@gmail.com GSSoC 2026 Participant
Added data-testid attributes for automated testing: - file-upload-zone: File upload drop zone - export-button: Export video button - export-progress: Progress bar during export - download-button: Download result button - reset-button: Reset/upload new video button - quality-slider: Quality CRF slider - speed-slider: Speed control slider Fixes reframe-oss#56 Contributor: Abhinav Jha (@Youngmaster0304) Email: abhinavjha0304@gmail.com GSSoC 2026 Participant
|
@Youngmaster0304 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ PR Format Check Passed — @Youngmaster0304Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
👋 Thanks for your PR, @Youngmaster0304!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
|
Thanks for the contribution! Another open PR (#1741: feat: add data-testid attributes to key UI elements for automated testing) tackles the same issue and is a bit further along (cleaner CI / no merge conflicts), so I'm consolidating there to keep review focused in one place. Closing this one — no reflection on the work itself, just avoiding split review across duplicates. Feel free to bring anything over to #1741 if it adds something that one doesn't have yet! |
What this does
Added data-testid attributes to key UI elements for automated testing.
Why
data-testid attributes allow Playwright or React Testing Library to reliably select elements without depending on CSS classes or text content.
Changes
file-upload-zone: File upload drop zoneexport-button: Export video buttonexport-progress: Progress bar during exportdownload-button: Download result buttonreset-button: Reset/upload new video buttonquality-slider: Quality CRF sliderspeed-slider: Speed control sliderAcceptance Criteria
data-testidattributesContributor
Abhinav Jha (@Youngmaster0304) | abhinavjha0304@gmail.com
GSSoC 2026 Participant
Fixes #56