feat: format trim times as MM:SS.d instead of raw seconds - #1716
Youngmaster0304 wants to merge 4 commits into
Conversation
Changed the h1 element in the header to a span element to ensure there is only one h1 per page (the main REFRAME title in VideoEditor). Fixes reframe-oss#69 Contributor: Abhinav Jha (@Youngmaster0304) Email: abhinavjha0304@gmail.com GSSoC 2026 Participant
Added title attributes to quick action buttons (Instagram Reels, TikTok, YouTube Short, YouTube, Twitter/X) showing exact dimensions. Fixes reframe-oss#71 Contributor: Abhinav Jha (@Youngmaster0304) Email: abhinavjha0304@gmail.com GSSoC 2026 Participant
Added data-testid attributes for automated testing: - file-upload-zone: File upload drop zone - export-button: Export video button - export-progress: Progress bar during export - download-button: Download result button - reset-button: Reset/upload new video button - quality-slider: Quality CRF slider - speed-slider: Speed control slider Fixes reframe-oss#56 Contributor: Abhinav Jha (@Youngmaster0304) Email: abhinavjha0304@gmail.com GSSoC 2026 Participant
Added formatTimeWithDecimal helper function and updated trim control labels to show formatted time (e.g., 01:05.5 instead of 65.5). Fixes reframe-oss#78 Contributor: Abhinav Jha (@Youngmaster0304) Email: abhinavjha0304@gmail.com GSSoC 2026 Participant
|
@Youngmaster0304 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ PR Format Check Passed — @Youngmaster0304Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
👋 Thanks for your PR, @Youngmaster0304!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
|
👋 This PR has been inactive for 21 days. It will be automatically closed in 14 days if there's no further activity. If you need help with this PR, please comment or ping a maintainer. |
|
Thanks for the contribution! Another open PR (#1570: fix: format trim times as minutes and seconds) tackles the same issue and is a bit further along (cleaner CI / no merge conflicts), so I'm consolidating there to keep review focused in one place. Closing this one — no reflection on the work itself, just avoiding split review across duplicates. Feel free to bring anything over to #1570 if it adds something that one doesn't have yet! |
What this does
Formatted trim times as MM:SS.d instead of raw seconds.
Why
Displaying time in raw seconds (e.g., 65.5) is not user-friendly. MM:SS.d format (e.g., 01:05.5) is more intuitive.
Changes
formatTimeWithDecimalhelper function insrc/lib/utils.tsAcceptance Criteria
Contributor
Abhinav Jha (@Youngmaster0304) | abhinavjha0304@gmail.com
GSSoC 2026 Participant
Fixes #78