Skip to content

feat: format trim times as MM:SS.d instead of raw seconds - #1716

Closed
Youngmaster0304 wants to merge 4 commits into
reframe-oss:mainfrom
Youngmaster0304:feat/trim-time-format
Closed

Youngmaster0304 wants to merge 4 commits into
reframe-oss:mainfrom
Youngmaster0304:feat/trim-time-format

Conversation

@Youngmaster0304

Copy link
Copy Markdown

What this does

Formatted trim times as MM:SS.d instead of raw seconds.

Why

Displaying time in raw seconds (e.g., 65.5) is not user-friendly. MM:SS.d format (e.g., 01:05.5) is more intuitive.

Changes

  • Added formatTimeWithDecimal helper function in src/lib/utils.ts
  • Updated trim control labels to show formatted time
  • Inputs still accept numeric seconds for editing

Acceptance Criteria

  • Duration shown as MM:SS format
  • Trim input labels show formatted time
  • Inputs still accept numeric seconds for editing

Contributor

Abhinav Jha (@Youngmaster0304) | abhinavjha0304@gmail.com
GSSoC 2026 Participant

Fixes #78

Changed the h1 element in the header to a span element to ensure
there is only one h1 per page (the main REFRAME title in VideoEditor).

Fixes reframe-oss#69

Contributor: Abhinav Jha (@Youngmaster0304)
Email: abhinavjha0304@gmail.com
GSSoC 2026 Participant
Added title attributes to quick action buttons (Instagram Reels,
TikTok, YouTube Short, YouTube, Twitter/X) showing exact dimensions.

Fixes reframe-oss#71

Contributor: Abhinav Jha (@Youngmaster0304)
Email: abhinavjha0304@gmail.com
GSSoC 2026 Participant
Added data-testid attributes for automated testing:
- file-upload-zone: File upload drop zone
- export-button: Export video button
- export-progress: Progress bar during export
- download-button: Download result button
- reset-button: Reset/upload new video button
- quality-slider: Quality CRF slider
- speed-slider: Speed control slider

Fixes reframe-oss#56

Contributor: Abhinav Jha (@Youngmaster0304)
Email: abhinavjha0304@gmail.com
GSSoC 2026 Participant
Added formatTimeWithDecimal helper function and updated trim control
labels to show formatted time (e.g., 01:05.5 instead of 65.5).

Fixes reframe-oss#78

Contributor: Abhinav Jha (@Youngmaster0304)
Email: abhinavjha0304@gmail.com
GSSoC 2026 Participant
@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown

@Youngmaster0304 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @Youngmaster0304

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Youngmaster0304!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix gssoc'26 GirlScript Summer of Code 2026 labels Aug 1, 2026
@magic-peach magic-peach added the status:awaiting-review Clean PR waiting on a maintainer, not the author label Aug 14, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

👋 This PR has been inactive for 21 days. It will be automatically closed in 14 days if there's no further activity.

If you need help with this PR, please comment or ping a maintainer.
Make sure your branch is rebased onto main and all CI checks pass.

@github-actions github-actions Bot added the needs-fixes PR has issues that need to be fixed label Sep 8, 2026
@magic-peach

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Another open PR (#1570: fix: format trim times as minutes and seconds) tackles the same issue and is a bit further along (cleaner CI / no merge conflicts), so I'm consolidating there to keep review focused in one place. Closing this one — no reflection on the work itself, just avoiding split review across duplicates. Feel free to bring anything over to #1570 if it adds something that one doesn't have yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts needs-fixes PR has issues that need to be fixed status:awaiting-review Clean PR waiting on a maintainer, not the author type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue] Format trim times as MM:SS instead of raw seconds

2 participants