fix(notary): validate claim response formats#352
Closed
jeremi wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This was referenced Jul 17, 2026
Member
Author
|
Superseded by current-base replacement PR #405, which preserves the accepted omitted/empty contract, separates registry evaluation formats from SD-JWT credential output, retains registry-backed-only issuance guards, and has passed independent current-base review. Closing this stale pre-v0.10 draft in favor of #405. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
formatslist to claim-result JSONWhy
An omitted or empty
formatslist previously deserialized to an empty vector. The configuration could load successfully, but evaluation would later reject even the default claim-result JSON response because the claim did not advertise it. Unknown or incomplete format declarations were likewise deferred until runtime.This makes the configuration boundary fail early while preserving the documented default for omitted fields.
Impact
Existing claims that omit
formatsnow work with claim-result JSON by default. Explicit lists must includeapplication/vnd.registry-notary.claim-result+jsonand may contain only the implemented claim-result JSON, CCCEV JSON-LD, and SD-JWT VC media types.Configurations with empty, incomplete, or unknown lists will fail to load until corrected.
Validation
cargo test --locked -p registry-notary-corecargo test --locked -p registry-notary --test doctor_clicargo test --locked -p registry-notary-servercargo clippy -p registry-notary-core -p registry-notary --all-targets -- -D warningsproducts/notary/just ci-preflightproducts/notary/just openapi-check