fix(auth): reject ambiguous primary credentials#408
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
jeremi
force-pushed
the
codex/1.0-200-credential-ambiguity
branch
from
July 17, 2026 13:15
0cf0423 to
7b57840
Compare
jeremi
marked this pull request as ready for review
July 17, 2026 13:41
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authorizationandx-api-keychannels from raw header presence before parsing or validating either valueauth.multiple_credentialsAddresses #200 and closes the candidate-neutral NP-24 implementation gap recorded by PR #403.
Security invariant
When more than one primary credential channel is present, the products must reject on presence before interpreting either credential. They must not select a preferred channel, reveal which credential was valid, disclose principal/scope/credential material, or reach downstream business/source dispatch.
Supplemental OIDC ID tokens are not primary credential channels and retain their existing semantics.
Behavior covered
Validation
abedb0098773486dbaaa80a8261c187c65676e6c; Cargo.lock unchangedOptional OpenAPI breaking-diff checks were skipped locally because no base ref was supplied; remote CI remains authoritative. Hadolint was unavailable locally.
Merge only after the full remote matrix is green on exact head
7b578408e914e912a9c91b3eba74ef4ca9961726.