Skip to content

chore(email-validation): sync daily disposable domains - #210

Merged
twinkalp10 merged 1 commit into
mainfrom
automated/sync-disposable-domains
Nov 13, 2026
Merged

twinkalp10 merged 1 commit into
mainfrom
automated/sync-disposable-domains

Conversation

@twinkalp10

@twinkalp10 twinkalp10 commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Automated daily sync of upstream disposable domain datasets.

Triggered by scheduled catalogue refresh.

RetriggerView in GreptileConfidence Score: 5/5

The dataset refresh appears safe to merge; no actionable defect was established.

Summary

Refreshes the upstream disposable-email datasets.

  • Email checks now include newly listed disposable domains.
  • Mail-server checks now use a refreshed list of disposable hosts.

Reviews (6) · Last reviewed commit: "chore(email-validation): sync daily disp..." · Reviewed by Greptile

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Review was skipped because the changed files are too large to review.

📏 Files whose diffs exceed the per-file size limit: 2

  • packages/email-validation/data/upstream/mx-domains.txt
  • packages/email-validation/data/upstream/domains.txt

Retrying the review will skip these files again. If they are generated content such as fixtures or snapshots, exclude them with reviews.path_filters (for example !**/fixtures/**).

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6ddd6229-6388-4a48-a32a-45017ba924e1
Commits

Reviewing files that changed from the base of the PR and between 07c445f and dfdd842.

Files selected for processing: 2

  • packages/email-validation/data/upstream/domains.txt
  • packages/email-validation/data/upstream/mx-domains.txt

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The upstream email-validation domain list adds entries across the alphabetically sorted list. It also removes one occurrence of 0droow.host; another occurrence remains.

Changes: Email validation domain list

Layer / File(s) Summary
Update domain list
packages/email-validation/data/upstream/domains.txt
The domain list gains entries. One occurrence of 0droow.host is removed, while another remains.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "chore(email-validation): sync daily disposable domains" matches the changeset. The only changed file is packages/email-validation/data/upstream/domains.txt, which adds 98 lines and removes …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "chore(email-validation): sync daily disposable domains" matches the changeset. The only changed file is packages/email-validation/data/upstream/domains.txt, which adds 98 lines and removes one occurrence of 0droow.host, and the PR objectives describe an automated daily sync of upstream disposable domain datasets. The title is concise, names the affected package, and states the primary change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Review coverage is incomplete: 1 file could not be fully reviewed. Findings from completed review steps are included; see review info for details.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1

packages/email-validation/data/upstream/domains.txt-88183-88183: 1

88183-88183: Major · Functional Correctness · Quick win

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Allowlist these business domains.

The businesses publish addresses at hanhansmarthome.com, kjelectrical.cn, and secerim.com. (hanhansmarthome.com)

Neither exception list includes these domains, so this change classifies their addresses as disposable. Consumers can reject legitimate users as a result. Add the domains to data/local/exceptions.txt, which survives upstream refreshes. (raw.githubusercontent.com)

Also applies to: 108817-108817, 171724-171724

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6837da55-2b04-4ef8-ba32-8dbceaf63f12
Commits

Reviewing files that changed from the base of the PR and between 07c445f and 6bc031b.

Files selected for processing: 2

  • packages/email-validation/data/upstream/domains.txt
  • packages/email-validation/data/upstream/mx-domains.txt
Files not fully reviewed because their changes were unavailable: 1

  • packages/email-validation/data/upstream/mx-domains.txt

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@twinkalp10
twinkalp10 force-pushed the automated/sync-disposable-domains branch from 6bc031b to fe687bc Compare November 8, 2026 09:52

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1

packages/email-validation/data/upstream/domains.txt-88220-88220: 1

88220-88220: Major · Functional Correctness · Quick win

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Allowlist the business domains.

These four domains publish company contact addresses on their websites. (hanhansmarthome.com)

Neither exception list contains them, so evaluate reports their addresses as disposable. Consumers can consequently reject legitimate business users. Add the domains to data/local/exceptions.txt so the fix survives refreshes. (raw.githubusercontent.com)

Also applies to: 108861-108861, 171791-171791, 216238-216238

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b0425868-d389-4877-b26c-e55ad50cf21b
Commits

Reviewing files that changed from the base of the PR and between 07c445f and fe687bc.

Files selected for processing: 2

  • packages/email-validation/data/upstream/domains.txt
  • packages/email-validation/data/upstream/mx-domains.txt
Files not fully reviewed because their changes were unavailable: 1

  • packages/email-validation/data/upstream/mx-domains.txt

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@twinkalp10
twinkalp10 force-pushed the automated/sync-disposable-domains branch 3 times, most recently from 91c6904 to 3ba30f0 Compare November 11, 2026 10:21
@twinkalp10
twinkalp10 force-pushed the automated/sync-disposable-domains branch from 3ba30f0 to dfdd842 Compare November 12, 2026 10:40
@twinkalp10
twinkalp10 merged commit 490180f into main Nov 13, 2026
3 of 4 checks passed
@twinkalp10
twinkalp10 deleted the automated/sync-disposable-domains branch November 13, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant