Skip to content

8. Add playground prediction controls and output#3107

Merged
anish-sahoo merged 5 commits into
cog-playgroundfrom
playground/4c-predictions
Jul 17, 2026
Merged

8. Add playground prediction controls and output#3107
anish-sahoo merged 5 commits into
cog-playgroundfrom
playground/4c-predictions

Conversation

@anish-sahoo

@anish-sahoo anish-sahoo commented Jul 14, 2026

Copy link
Copy Markdown
Member

@ask-bonk

ask-bonk Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

I reviewed all 22 files in PR #3107 by reading the core implementation (hooks, utils, components) and tests. I identified one issue where the async prediction flow's eventSourceReady promise rejection is unhandled if the EventSource fails before the onerror handler is attached, which could cause an unhandled promise rejection.

github run

@anish-sahoo anish-sahoo changed the title Add playground prediction controls and output 8. Add playground prediction controls and output Jul 14, 2026
@anish-sahoo

Copy link
Copy Markdown
Member Author

Reviewed the reported EventSource race. eventSourceReady installs onerror synchronously in its Promise executor; connection failures are awaited in run()'s try/catch, and the post-open handler is attached before a later browser task can deliver an error. No unhandled rejection path was found, so no code change is needed. Existing coverage includes post-connect failure and connection timeout.

This is a top-level comment, so GitHub provides no review thread to resolve.

@ask-bonk

ask-bonk Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@ask-bonk

ask-bonk Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@ask-bonk

ask-bonk Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@anish-sahoo Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@anish-sahoo
anish-sahoo merged commit 1a44463 into cog-playground Jul 17, 2026
1 check failed
@anish-sahoo
anish-sahoo deleted the playground/4c-predictions branch July 17, 2026 19:06
@ask-bonk

ask-bonk Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@ask-bonk

ask-bonk Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

fatal: couldn't find remote ref playground/4c-predictions

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants