[VQueues] Purge obsolete metadata inline - #5308
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for creating this PR @AhmedSoliman. Deleting obsolete vqueue metadata makes a lot of sense to me. There is one thing to clarify before merging which is whether we want to keep the secondary map in the DRRScheduler in sync with the vqueue meta cache or not.
| .into_inner()?; | ||
| let at = UniqueTimestamp::from_unix_millis_unchecked(self.record_created_at); | ||
| for qid in pause.vqueues.iter() { | ||
| let Some(mut vqueue) = VQueue::get( |
There was a problem hiding this comment.
After an offline discussion: Maybe add a comment stating that we want to ship vqueue pausing after enabling the clean up of obsolete vqueue metadata.
|
|
||
| if delete_after.is_zero() { | ||
| // Delete immediately! | ||
| self.delete( |
There was a problem hiding this comment.
As a breadcrumb: Here the DRRScheduler.q field might go out of sync with the vqueue meta cache if the ending invocation is not inboxed (e.g. running).
Delete unpaused VQueue metadata when the last entry is removed. Return a disposition so cache detachment remains event-safe and same-batch recreation uses a fresh handle.
94f12da to
86c6bce
Compare
|
@codex review |
1 similar comment
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Delete unpaused VQueue metadata when the last entry is removed. Return a disposition so cache detachment remains event-safe and same-batch recreation uses a fresh handle.