Wrap long values in Pivot's cell hover tooltip - #9857
Open
nishantmonu51 wants to merge 2 commits into
Open
Conversation
The Pivot's hover tooltip renders through `TooltipTitle`, which hard-coded `truncate` on the value, so long cell values collapsed to a single ellipsized line regardless of the tooltip's width. Explore's leaderboard doesn't share this component, which is why wrapping already worked there. `TooltipTitle` now takes a `wrap` prop (default off, preserving the ~30 other call sites), and `VirtualTooltip` (used by the Pivot and dimension table) opts in. Claude-Session: https://claude.ai/code/session_011b89i38746941dRXzqWSXd
AdityaHegde
approved these changes
Sep 4, 2026
`break-words` alone did not wrap the values this change targets. Without `overflow: hidden` the name is a grid item sized to its min-content width, and `overflow-wrap: break-word` contributes no break opportunities to min-content, so a single unbroken token (a URL, a UUID) overflowed the 360px tooltip instead of wrapping. `min-w-0` lets the item shrink so the break actually happens. Also scope `wrap` to cell values: header tooltips in the source/model preview keep their previous single-line ellipsis, and the type in the description slot stays baseline-aligned. Claude-Session: https://claude.ai/code/session_01NGUuWWbkeCTrYXrDPLwXG3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long cell values in the Pivot's hover tooltip were getting cut off to a single ellipsized line, even though the tooltip has room to grow. Full long-text wrapping on hover already worked on the Explore dashboard.
TooltipTitle's value now supports wrapping across multiple lines via a newwrapprop, opt-in and off by default so existing usages (~30 call sites) are unaffected.VirtualTooltip(used by the Pivot and dimension table) opts in.Checklist: