Skip to content

fix(pi): read an app credential with one source call #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eersnington merged 1 commit into from
Oct 8, 2026
Merged

fix(pi): read an app credential with one source call #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions packages/pi/src/credentials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export interface PiCredentialInfo {
export interface PiCredentialSource {
/** Providers that have a credential. */
list(): Promise<PiCredentialInfo[]>;
/** A provider's credential, possibly expired. */
/** A provider's credential, possibly expired, or `undefined` when it has none. */
read(providerId: string): Promise<PiProviderCredential | undefined>;
/**
* A provider's credential after the application refreshed it. Pi calls this
Expand All @@ -42,9 +42,10 @@ const PI_OAUTH_MIN_VALIDITY_MS = 5 * 60_000;

/**
* Adapts an application's credential source to Pi's credential store. It
* reads only providers the source lists, asks the source each time Pi needs a
* credential, so logins and logouts apply to the next model call, and never
* writes.
* asks the source each time Pi needs a credential, so logins and logouts
* apply to the next model call, and never writes. Pi's `{ signal }` is not
* passed on, because a source is often an Actor handle, whose actions would
* receive the signal as an argument.
*/
export class SourceCredentialStore implements PiCredentialStore {
readonly #source: PiCredentialSource;
Expand All @@ -58,8 +59,6 @@ export class SourceCredentialStore implements PiCredentialStore {
}

async read(providerId: string): Promise<PiCredential | undefined> {
if (!(await this.list()).some((entry) => entry.providerId === providerId))
return undefined;
return toPiCredential(await this.#source.read(providerId));
}

Expand Down
Loading