Repository navigation
Conversation
…nd black The stylesheet paints every canvas black, and the sight's overlay is a canvas over the picture, so capturing the mouse in Vs. Duck Hunt on web covered the game. The overlay now declares a transparent background. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QmNN1L1G3mw6Daxa3WfkCj
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QmNN1L1G3mw6Daxa3WfkCj
Owner
Author
|
Review (cold read, No blocking findings. The reviewer checked the cause against the code:
The inline
Producer's answers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bead: nr-use (Vs. Duck Hunt cannot be played). This answers the verification failure of 2026-10-25 at fbcd199.
The bug
On web, the picture went black whenever the mouse was captured and the Zapper sight showed. Escape brought it back. The sight is drawn on a second canvas laid over the game picture. #3352 (Steel Glow) added
canvas { background: #000 }toweb/main.cssfor every canvas, so that overlay turned into an opaque black sheet. The Super Scope sight uses the same overlay, so it had the same problem.The fix
createCrosshairnow gives its overlay an inlinebackground: transparent. The game canvas keeps its black backing.Reproduction test
web/src/display/crosshair_overlay_style.test.tsloads the realmain.cssinto jsdom, creates the sight over a#screencanvas, and checks the overlay's computed background. It gotrgb(0, 0, 0)before the fix and getsrgba(0, 0, 0, 0)now.Validation
./scripts/gate-full.sh --fast: passedpnpm run typecheck: passed.pnpm test: 96 files and 1043 tests passedNot changed here: right after capture, the sight is drawn at the top-left corner until the mouse first moves. That was already the case before this fix.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QmNN1L1G3mw6Daxa3WfkCj