Repository navigation
Conversation
…n ubuntu-24.04
ubuntu-latest moved to Ubuntu 26.04, which Playwright 1.60 refuses
("Playwright does not support chromium on ubuntu26.04-x64"), so
web-container failed before testing anything. Pin web-container and
web-integration to ubuntu-24.04, the image they were green on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WCDKexBLzRiHm26TufpEph
|
Review (cold read, The change matches the bug claim. The pin covers exactly the two jobs that run
|
…mage Review of #3396: a cached Chromium skips the install step, which is what hid the ubuntu26.04 failure in web-integration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCDKexBLzRiHm26TufpEph
|
Answers to the review: 1. Done in 702a9a2. The cache key now reads |
…he hid it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCDKexBLzRiHm26TufpEph
Bead: nr-7sn1 (bug, P0). No GitHub issue.
The bug
GitHub moved
ubuntu-latestto Ubuntu 26.04. Playwright 1.60.0, the version in our lockfile, refuses that image:playwright install chromiumfails with "Playwright does not support chromium on ubuntu26.04-x64". So web-container failed before running any test (PR #3395, twice). web-integration also ran onubuntu-latestand passed only because its browser came from the cache.The fix
web-containerandweb-integrationnow run onubuntu-24.04, the image they were last green on. A comment beside each says why, and that moving off it goes together with a Playwright upgrade.I decided against upgrading Playwright to 1.64.1, which does list ubuntu26.04. It would change the browser every web test runs against and touch the lockfile, and the bead's scope excludes test changes beyond what the runner forces. That upgrade can be its own bead.
Reproduction test
scripts/test_playwright_runner_image.pychecks every ci.yml job that runsplaywright install:ubuntu-24.04. Before the fix this failed for both jobs ('ubuntu-latest' != 'ubuntu-24.04').Validation
./scripts/gate-full.sh --fast: passed. The change is non-Rust; build-workload classifies itnon-rust.🤖 Generated with Claude Code
https://claude.ai/code/session_01WCDKexBLzRiHm26TufpEph