Skip to content

feat(rq-qz71): With the words open, Hearth and Lantern keep their dots - #1107

Merged
rmstdope merged 2 commits into
mainfrom
rq-qz71-with-the-words-open-hearth-and-lantern
Nov 11, 2026
Merged

rmstdope merged 2 commits into
mainfrom
rq-qz71-with-the-words-open-hearth-and-lantern

Conversation

@rmstdope

Copy link
Copy Markdown
Owner

Bead rq-qz71. Dots under the words (cards, spoken lines) no longer vanish: clearOfWords steps them straight above/below to just outside the words, or onto the nearest word edge (half over the card) when no free picture is near; keepMarksApart keeps them apart (edge marks slide along the edge). Names, press, focus and hiding the words reuse the existing rules.

Validation: eslint, prettier --check, vue-tsc, npm run test (6960), npm run build all green; playwright 199/200 — narrationCards:27 failed once in the full run and passed alone (unrelated to dots). Not done: a visual look at Elior's Cottage 1000x700 (covered by unit tests of the same geometry).

Formatting constraints verified.

🤖 Generated with Claude Code

@rmstdope

Copy link
Copy Markdown
Owner Author

Review (cold read, reviewed_head: 90a3232907c9ddacfa54213681023d09fb3107e8) — reviewed before merge under the producer's review practice, by an agent given the diff and the bead, and not the producer's reasoning.

  1. (blocking) clearOfWords fallback could stand the dot wholly inside a card that reaches the visible edge, or under a panel.
  2. (question) "half over the card": the names layer lies beneath the cards, so the edge dot is half hidden; needs eyes in a real browser.
  3. Component assertions (y !== 270, y !== 405) cannot tell a right dot from a wrong one.
  4. The agreed check case (plate + cards, Shelves in the gap) is not exercised; e2e was skipped without a recorded reason.
  5. (suggestion) onWords marks may slide past the end of their card.
  6. (suggestion) stale "waits unseen / hide a mark" comments in areaNames.ts.

Producer's answers (head 8a94ca75385258bb646d2abf145d2ab29d533fbd)

  1. Fixed: the fallback now ranks edges: under no panel, at most half the dot inside the words, least depth, nearest. Tests added (panel-barred sides, card reaching the foot). Where both edges are equally poor (words fill the whole picture) the dot is as near the edge as the visible part allows.
  2. Not changed: the acceptance and mockup say "half over the card", so the visible half is the pressable one. Left for the verifier's look in a real browser.
  3. Fixed: assertions now require an edge position or a stepped spot.
  4. Added a component test with a plate above a card (dot steps past the cards); the e2e of the Elior's Cottage case is not added, the human check stays under Validation for the verifier.
  5. Fixed: an edge mark slides only within the x-span of some words rect; test added.
  6. Fixed: the four comments reworded.

@rmstdope
rmstdope merged commit 5a09e8a into main Nov 11, 2026
7 checks passed
@rmstdope
rmstdope deleted the rq-qz71-with-the-words-open-hearth-and-lantern branch November 11, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant