Repository navigation
fix(rq-cm21): A stepped dot kept apart from its neighbour never slides into the words - #1109
Conversation
…s into the words keepMarksApart checked only a slid dot's middle against the cards and spoken lines, so a dot could land half under a line. A spot a mark slides to now keeps the whole dot off the words. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCDKeye47AT4ZyGRvKH933
… out Navigator's answer to review finding 1: rather than jump across the spoken line, a slid mark whose slide reaches the words moves on to the next row, beside its neighbour. The test now asserts the full 8px. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCDKeye47AT4ZyGRvKH933
|
Review (cold read,
|
|
Answers to the review (fixes in
|
… on the other side Delta review: the words ending a slide left two dots stacked when no row lay further out. The other side is now tried in a second pass, never across the words; a level spot touching the words no longer ends the row. The row test now matches the cottage (stepped up, row above). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCDKeye47AT4ZyGRvKH933
|
Review (follow-up delta,
|
|
Answers to the follow-up review (fixes in the head after
|
|
Review (follow-up delta, All five previous answers checked against the code and confirmed (the foot test fails on
|
|
Answer to the third review
|
Bead: rq-cm21 (bugfix).
Bug:
keepMarksApartjudged a spot a dot slides to by its middle alone, so Books (giving way to Shelves in Elior's Cottage, words open) landed with its right half under the short spoken line and a press on its centre did nothing.Fix: a spot a mark slides to must keep its whole dot (
MARK_RADIUSfrom its middle) off the words. The spot a mark already stands on is judged as before, so unblocked marks do not move.Reproduction test:
areaNames.test.ts› keepMarksApart › never slides a stepped mark so its dot lies half under the words beside it (red before: dot middle 1px from the words; green after).Validation: fast gate green (eslint, prettier, vue-tsc, vitest 6968 tests).
Formatting constraints verified.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WCDKeye47AT4ZyGRvKH933